Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drl 59/implement shellspec #23

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Drl 59/implement shellspec #23

merged 5 commits into from
Mar 26, 2024

Conversation

msterle
Copy link
Contributor

@msterle msterle commented Mar 26, 2024 •
edited
Loading

Solves DRL-59

  • Added shellspec to repo
  • Added a sample test file
  • Added shellspec to github workflow
  • Added pot mock
  • Updated README

dblane-digicatapult
dblane-digicatapult requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@dblane-digicatapult dblane-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent start, would be useful if we can add this to the development part of the README.md showing them how to use this locally.

Also would you be able to create a mock for a load of the pot sub-commands?

@msterle msterle merged commit 863576b into main Mar 26, 2024
2 checks passed
@msterle msterle deleted the DRL-59/implement-shellspec branch March 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblane-digicatapult dblane-digicatapult dblane-digicatapult approved these changes

Assignees

@dblane-digicatapult dblane-digicatapult

@elisehaldane elisehaldane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msterle @dblane-digicatapult @elisehaldane