Refine stability rules for diesel release #4503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly outlines that we might perform otherwise considered breaking changes in minor releases if that's required by build breaking changes from the rust project itself. A previous example of such a change that nearly required us to make such a breaking change in diesel is the change to default to `resolver = "2"` with the 2021 edition. I rather want to make sure that we don't end up in a similar situation in the future that requires us to issue a new major diesel version just to sidestep0breakage from their side.
|
To add some context on why I want to change this: https://blog.weiznich.de/blog/cargo-instablity/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit explicitly outlines that we might perform otherwise considered breaking changes in minor releases if that's required by build breaking changes from the rust project itself. A previous example of such a change that nearly required us to make such a breaking change in diesel is the change to default to
resolver = "2"with the 2021 edition. I rather want to make sure that we don't end up in a similar situation in the future that requires us to issue a new major diesel version just to sidestep0breakage from their side.