Make sqlite value function public #4480
Merged
+156
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
feature/public_read_functions_for_sqlite_value
branch
from
bb9638f to
33ed970
Compare
This commit turns the `read_*` functions of the `SqliteValue` type into public functions, which makes it easier for third party crates to access the underlying sqlite values in a performant way. This enables crates to not clone for example the string, but rather reuse the string slice we got from sqlite instead. This also turns all these functions into methods that require a mutable reference instead of a shared reference as technically each of those methods might mutate the underlying value according to the sqlite documentation.
weiznich
force-pushed
the
feature/public_read_functions_for_sqlite_value
branch
from
33ed970 to
c1688e3
Compare
JohnTitor
approved these changes
Feb 12, 2025
| use crate::sql_types::{Blob, Double, Int4, Text}; | ||
| use crate::*; | ||
|
|
||
| #[expect(clippy::approx_constant)] // we really want to use 3.14 |
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Feb 14, 2025
This commit prepares a 2.2.8 release that includes the following changes: * diesel-rs#4472 * diesel-rs#4484 * diesel-rs#4486 * diesel-rs#4480
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Feb 14, 2025
This commit prepares a 2.2.8 release that includes the following changes: * diesel-rs#4472 * diesel-rs#4484 * diesel-rs#4486 * diesel-rs#4480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit turns the
read_*functions of theSqliteValuetype into public functions, which makes it easier for third party crates to access the underlying sqlite values in a performant way. This enables crates to not clone for example the string, but rather reuse the string slice we got from sqlite instead.This also turns all these functions into methods that require a mutable reference instead of a shared reference as technically each of those methods might mutate the underlying value according to the sqlite documentation.