Skip to content

Commit

Permalink
Use ignore for unsupported tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Spxg committed Feb 11, 2025
1 parent 7928a8d commit f238fde
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
4 changes: 2 additions & 2 deletions diesel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ path = "../diesel_derives"
libsqlite3-sys = { version = ">=0.17.2, <0.32.0", optional = true, features = ["bundled_bindings"] }

[target.'cfg(all(target_family = "wasm", target_os = "unknown"))'.dependencies]
sqlite-wasm-rs = { version = ">=0.2.2, <0.3.0", optional = true }
sqlite-wasm-rs = { version = ">=0.2.4, <0.3.0", optional = true }

[target.'cfg(all(target_family = "wasm", target_os = "unknown"))'.dev-dependencies]
# Something is dependent on it, so we use feature to override it.
# Something is dependent on it, we use feature to override it.
getrandom = { version = "0.2", features = ["js"] }
wasm-bindgen-test = "0.3.49"

Expand Down
17 changes: 12 additions & 5 deletions diesel_tests/tests/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ use crate::schema::*;
use diesel::connection::BoxableConnection;
use diesel::*;

#[cfg_attr(
all(target_family = "wasm", target_os = "unknown"),
ignore = "can't sleep"
)]
#[diesel_test_helper::test]
#[cfg(any(feature = "postgres", feature = "sqlite"))]
#[cfg(not(all(target_family = "wasm", target_os = "unknown")))]
fn managing_updated_at_for_table() {
use crate::schema_dsl::*;
use chrono::NaiveDateTime;
Expand Down Expand Up @@ -79,10 +82,12 @@ fn managing_updated_at_for_table() {
assert!(old_time < new_time);
}

/// wasm does not support `std::env::temp_dir`
#[cfg_attr(
all(target_family = "wasm", target_os = "unknown"),
ignore = "no filesystem on this platform"
)]
#[diesel_test_helper::test]
#[cfg(feature = "sqlite")]
#[cfg(not(all(target_family = "wasm", target_os = "unknown")))]
fn strips_sqlite_url_prefix() {
let mut path = std::env::temp_dir();
path.push("diesel_test_sqlite.db");
Expand All @@ -99,10 +104,12 @@ fn file_uri_created_in_memory() {
assert!(!Path::new(":memory:").exists());
}

/// wasm does not support `std::env::temp_dir`
#[cfg_attr(
all(target_family = "wasm", target_os = "unknown"),
ignore = "no filesystem on this platform"
)]
#[diesel_test_helper::test]
#[cfg(feature = "sqlite")]
#[cfg(not(all(target_family = "wasm", target_os = "unknown")))]
fn sqlite_uri_prefix_interpreted_as_file() {
let mut path = std::env::temp_dir();
path.push("diesel_test_sqlite_readonly.db");
Expand Down

0 comments on commit f238fde

Please sign in to comment.