Skip to content

fix(select): adjust spacing, padding, clear icon #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cooper-joe
Copy link
Member

This PR makes minor changes to the select component:

  • Adjusts padding and spacing of the end-aligned components (down-arrow and clear action)
  • Prevents clear button icon shrinking

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

Before:

image

After:

image

@cooper-joe cooper-joe requested a review from a team as a code owner April 14, 2025 10:25
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1680--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 14, 2025 10:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants