Multiple Selection #9
Conversation
|
It seems there was a bug that allowed for the deletion of a time slot if it was in between different days. I started testing it now since I'm going to integrate it. For now I'll use patch-package. |
|
@bearkillerPT Thanks for the contribution, let me check and I will let you know. |
|
@bearkillerPT can you create runnable example in expo like the one i have here expo |
| title = 'Select time', | ||
| backgroundColor = theme.colors.white, | ||
| }: Props) => { | ||
| const onPress = (value: string) => { | ||
| setSelectedTime(value); | ||
| if (!scheduledAppointments || scheduledAppointments.length === 0) |
There was a problem hiding this comment.
This needs to be refactored in a utility function is different file. The multiple if-else statements are not helping to understand the logic. Can you please add comments or refactor the code to be more development friendly?
There was a problem hiding this comment.
This needs to be refactored in a utility function is different file. The multiple if-else statements are not helping to understand the logic. Can you please add comments or refactor the code to be more
developmentfriendly?
Added comments that I think explain well what's going on. I agree with the util functions file but didn't have the time to do it yet 😞
I've modified the example app inside it. I tested with that. |
Hey there! Found this lib yesterday and it's just what I need! Here's what I did:
Don't ask me why but for the first 3 commit's the pre-commit hook didn't run and alert me about the conventions used.
I also have a function that I still have to perfect but I think it would be cool to add to the ultilities. It's a function that given a timeInterval and numberOfDays produces the array of available slots.
Thanks for creating the lib!