Skip to content

API v2 delete event #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
11 tasks done
c8y3 opened this issue Mar 24, 2025 · 1 comment · Fixed by #776
Open
11 tasks done

API v2 delete event #762

c8y3 opened this issue Mar 24, 2025 · 1 comment · Fixed by #776
Assignees
Labels
enhancement New feature or request

Comments

@c8y3
Copy link
Contributor

c8y3 commented Mar 24, 2025

Implement endpoint DELETE /api/v2/cases/{case_identifier}/events/{identifier} to delete an evidence.

  • return 204 in case of success
  • create method in the business layer
  • GET /api/v2/cases/{case_identifier}/events/{identifier} returns 404, after delete
  • return an empty body in case of success
  • return 404 when the case is not found
  • return 404 when the event is not found
  • return 403 when user is denied permission to case
  • returns 400 when case_identifier is not the identifier of the case of the event
  • deprecate POST /case/timeline/events/delete/{event_id}
  • openapi: document endpoint
  • openapi: deprecate POST /case/timeline/events/delete/{event_id}
@c8y3 c8y3 added the enhancement New feature or request label Mar 24, 2025
@c8y3 c8y3 self-assigned this Mar 24, 2025
@c8y3
Copy link
Contributor Author

c8y3 commented Apr 11, 2025

  • Fix: DELETE /api/v2/cases/{case_identifier}/evidences/{identifier} evidence when user has no permission to access case should not delete evidence
  • removed the adherence of the event business layer with marshmallow and the schema (moved up in the API)
  • deprecated create and update events preload hooks
  • openapi: removed some lint warnings
  • Removed endpoint GET /manage/server/check-updates/modal
  • Removed endpoint GET /manage/server/make-update
  • Fixed all remaining occurrences and activate ruff rule RET506
  • Moved some methods from app.util closer to their use in namespace app.schema.utils
  • Created class Events so as to avoid to duplicate and recreate the EventSchema several times in the code (and at runtime)

@c8y3 c8y3 linked a pull request Apr 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant