-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mops and call mops sources
with --no-install
flag
#293
Conversation
Thanks for the fix! How recently was the |
Here is what I'm imagining (updating the error message slightly below the original code change): throw new Error(
`Error while finding Mops packages.\nMake sure the latest version of Mops is installed locally or globally (https://mops.one/docs/install).\n${err?.message || err}`,
); The CI error should be fixable by running |
In
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; let's revisit this in a few weeks.
It would be ideal if we could use a solution that also works for previous versions of Mops (or at least keeps the original behavior for previous versions), but on the other hand, it would be mostly trivial and beneficial for everyone to update to the latest version.
A possibly problematic counterexample is where an example / starter project includes a specific version of ic-mops
in their dev dependencies (a somewhat common pattern), which would result in error messages for anyone using the starter project regardless of their local Mops version. For these cases, it would be good for us to support previous Mops versions if possible.
Added mops version check |
I just got a chance to check back on this. Thanks for the update! Merged. |
Sometimes errors may occur when a user runs
mops install
because ext callsmops sources
which starts withmops install
, so we get two concurrent install processes. With--no-install
flag this problem should go away.