Remove the script to send conversion rate proposals #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
approved these changes
Feb 7, 2025
jasonz-dfinity
force-pushed
the
jason/NNS1-3131
branch
from
910fb3e to
8ee39fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We no longer send conversion rate proposals on the mainnet, and in the test environment CMC already sets a default exchange rate (commit). This PR is required before we make the proposal type obsolete in NNS Governance.
What
bin/dfx-nns-propose-xdr-icp-conversion-ratebin/dfx-network-deploy-configTests
./bin/dfx-snapshot-stock-makestill works, and the snapshot can be used to create an environment where NNS Dapp can be accessed and the launched SNSes can be seen (launching SNSes require knowing conversion rate)