Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove saving state from demo workflow #447

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove saving state from demo workflow #447

merged 1 commit into from
Feb 3, 2025

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Feb 3, 2025

Motivation

The "non-interactive demo" workflow broke because it used actions/upload-artifact: v3, which is no longer supported, to upload a saved state.

But there is no reason for the demo workflow to upload a saved state in the first place. We already have the "snapshot" workflow, which creates a snapshot and includes it in a release.

Change

Stop saving and uploading the state in the demo workflow.

Tested

CI should pass again.

@dskloetd dskloetd marked this pull request as ready for review February 3, 2025 08:46
@dskloetd dskloetd requested a review from a team as a code owner February 3, 2025 08:46
@dskloetd dskloetd enabled auto-merge (squash) February 3, 2025 08:47
@dskloetd dskloetd mentioned this pull request Feb 3, 2025
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd merged commit ee52dce into main Feb 3, 2025
16 checks passed
@dskloetd dskloetd deleted the kloet/no-upload branch February 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants