chore: Misc output changes #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| info!(log, " - {}", green.apply_to(url1)); | ||
| info!(log, " - {}", green.apply_to(url2)); | ||
| #[rustfmt::skip] | ||
| info!(log, " - {} (Recommended)", green.apply_to(subdomain_url)); |
There was a problem hiding this comment.
"recommended" doesn't work on Safari, yes?
There was a problem hiding this comment.
Yes, hence 'legacy'. I had trimmed that down from 'legacy/safari' because 'safari' implies that the website will actually work with safari, and it won't. Not sure if there's a good way to phrase it without taking up too much space.
ericswanson-dfinity
previously approved these changes
Feb 13, 2025
lwshang
approved these changes
Feb 14, 2025
adamspofford-dfinity
added a commit
that referenced
this pull request
Feb 18, 2025
adamspofford-dfinity
added a commit
that referenced
this pull request
Feb 18, 2025
adamspofford-dfinity
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK-1890, SDK-1893, SDK-1899