Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: detect errors in command pipelines #3513

Merged
merged 4 commits into from
Jan 18, 2024
Merged

test: detect errors in command pipelines #3513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b245ab0
fix: set -i and -o pipefail in e2e tests
ericswanson-dfinity Jan 17, 2024
a8aa5fa
remove -u
ericswanson-dfinity Jan 17, 2024
b634c8e
jq fails if input file does not exist
ericswanson-dfinity Jan 18, 2024
11619e3
revert branch exec
ericswanson-dfinity Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/tests-dfx/schema.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ teardown() {
}

@test "dfx schema still works with broken dfx.json" {
jq '.broken_key="blahblahblah"' dfx.json | sponge dfx.json
echo '{}' | jq '.broken_key="blahblahblah"' > dfx.json
assert_command dfx schema
}
2 changes: 1 addition & 1 deletion e2e/utils/_.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set -e
set -eo pipefail
load ../utils/bats-support/load
load ../utils/assertions
load ../utils/webserver
Expand Down
Loading