From f717d7562476ea8576c1a234a73d3d34a09a89f1 Mon Sep 17 00:00:00 2001 From: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com> Date: Tue, 19 Dec 2023 11:07:09 -0800 Subject: [PATCH] test: require UI test to pass for CI (#3483) See https://github.com/dfinity/sdk/actions/runs/7265443777/job/19796376801 for an example where the UI test failed but the `e2e:required` status passed anyway and the PR was merged. --- .github/workflows/e2e.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index b3fc7470fd..94b4d4c803 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -201,6 +201,9 @@ jobs: - name: check smoke test result if: ${{ needs.smoke.result != 'success' }} run: exit 1 + - name: check UI test result + if: ${{ needs.ui_test.result != 'success' }} + run: exit 1 - name: check e2e test result if: ${{ needs.test.result != 'success' }} run: exit 1