Skip to content

Commit

Permalink
test: require UI test to pass for CI (#3483)
Browse files Browse the repository at this point in the history
See https://github.com/dfinity/sdk/actions/runs/7265443777/job/19796376801 for an example where the UI test failed but the `e2e:required` status passed anyway and the PR was merged.
  • Loading branch information
ericswanson-dfinity authored Dec 19, 2023
1 parent 3056145 commit f717d75
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ jobs:
- name: check smoke test result
if: ${{ needs.smoke.result != 'success' }}
run: exit 1
- name: check UI test result
if: ${{ needs.ui_test.result != 'success' }}
run: exit 1
- name: check e2e test result
if: ${{ needs.test.result != 'success' }}
run: exit 1

0 comments on commit f717d75

Please sign in to comment.