Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [MR-662] Add CyclesUseCase::DroppedMessages variant #4283

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

alin-at-dfinity
Copy link
Contributor

This is in preparation for tracking cycles lost when dropping (shedding or timing out) messages.

This is in preparation for tracking cycles lost when dropping (shedding or timing out) messages.
@alin-at-dfinity alin-at-dfinity requested review from a team as code owners March 7, 2025 16:42
@github-actions github-actions bot added the feat label Mar 7, 2025
Copy link
Contributor

@berestovskyy berestovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I hope it's covered by tests...

Copy link
Contributor

@stiegerc stiegerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alin-at-dfinity alin-at-dfinity added this pull request to the merge queue Mar 11, 2025
Merged via the queue into master with commit 5ed9bb9 Mar 11, 2025
21 checks passed
@alin-at-dfinity alin-at-dfinity deleted the alin/MR-662-add-CyclesUseCase-DroppedMessages branch March 11, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants