feat: EXC-1968: Add signal handler duration metric #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berestovskyy
force-pushed
the
andriy/remove-dts-workaround
branch
from
df9d19e to
f3a08dd
Compare
berestovskyy
force-pushed
the
andriy/exc-1968-signal-handler-time
branch
from
a92a06f to
7eac58b
Compare
berestovskyy
force-pushed
the
andriy/remove-dts-workaround
branch
from
f3a08dd to
fbfabbe
Compare
berestovskyy
changed the base branch from
andriy/remove-dts-workaround
to
master
berestovskyy
force-pushed
the
andriy/exc-1968-signal-handler-time
branch
from
7eac58b to
7ecdcf9
Compare
berestovskyy
force-pushed
the
andriy/exc-1968-signal-handler-time
branch
from
7ecdcf9 to
93eed7c
Compare
dsarlis
reviewed
Mar 13, 2025
rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs
Outdated
Show resolved
Hide resolved
berestovskyy
commented
Mar 13, 2025
Co-authored-by: Dimitris Sarlis <dimitrios.sarlis@dfinity.org>
dsarlis
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new signal handler metric
sandboxed_execution_sigsegv_handler_duration_secondsshould provide insights into the signal handler's execution time, in addition to the currently available number of system calls and operations.