Newfeature/pull requests #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded for the 'pull requests' section
- Adding pull requests draft (without screenshots) - Renaming making a development branch file to remove typo
- Adding instruction to go to gitlog and update to save they have made a dev branch to be able to later pull make into their main branch - Removing VS code picture for now as have never used and can't work out how
…how to push (to make pull requests section flow better)
- Updating git to Git - Adding screengrabs
- Adding section on reviewing PRs - Deleting unused screengrab - Haven't gone into detail on conflict resolution - another tab?
rmbielby
requested changes
Feb 10, 2025
Co-authored-by: Rich Bielby <richard.bielby@education.gov.uk>
Co-authored-by: Rich Bielby <richard.bielby@education.gov.uk>
Amending based on Rich's feedback * Changing making a development branch to 'making more branches' * splitting pull requests out into two pages - creating and reviewing a PR * Moving two pull requests and associated images to github-devops-refresher section
rmbielby
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes
Pull request to ask for feedback on structure and new content
Why are these changes being made?
These changes have been made to add information on creating a development branch and pull requests into Git Academy
Reviewer instructions
Please could you give some general feedback on if how I have laid this out seems okay before I perfect it. I have purposely not gone into detail on resolving conflicts as it feels like it would be too much and needs its own section. I have tried to add in the different methods where I am able - are all the right methods there?