Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight change to the new custom disconnect message #76

Closed
2 of 3 tasks
JT-39 opened this issue Dec 24, 2024 · 2 comments
Closed
2 of 3 tasks

Slight change to the new custom disconnect message #76

JT-39 opened this issue Dec 24, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@JT-39
Copy link
Collaborator

JT-39 commented Dec 24, 2024

Is your feature request related to a problem? Please describe.

Thanks for updating the custom disconnect message function with the ability to add a different email and a specific link. But in my head I was thinking these would also be able to added as additional options (as well as replacements).

So,

  1. I could point towards explore.statistics@education.gov.uk and another email (although this may be confusing? maybe it is best to just have one?).
  2. I can have the refresh link and a separate "Reset page" or "Back to default" link (aka the initial view) - gives users choice so that if they want to return to their original selections they can (especially with the timeout being quick), but if this causes a continuous error then they can definitely get back to a working app link.
  3. The default Posit reload pop-up is still appearing (see below image) - I feel like this didn't used to appear, as it looks a little clunky (personal preference -not sure if we can hide it).

image

Describe the solution you'd like

@cjrace
Copy link
Contributor

cjrace commented Dec 30, 2024

I think we'd want to keep it to a single email address so it's simpler for users, they just have one contact point to go to. The other two should be possible though - have made them into separate issues so they can be done in separate PRs if easier. The default posit thing really shouldn't be showing, it never used to as we hid it, so that's a bug we've introduced at some point!

@cjrace
Copy link
Contributor

cjrace commented Jan 2, 2025

In fact, I'm going to close this in favour of the other two issues I copied info into to avoid confusion / duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants