Add a SAML connector option to allows SAML request to be sent using RedirectBinding #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
|
Hi @nabokihms, can I ask you to take a look at this? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some IDP ( like Canonical's SSO ) systematically drops incoming POST requests. This PR adds the option for Dex to use HTTP redirect to send its SAML request, providing more flexibility.
What this PR does / why we need it
This PR adds a new attribute
bindingTypeto the SAML connector configuration, the default value ispostso this won't change the behavior of existing configs. Updating this value toredirectwill prompt Dex to send the SAML request via a HTTP Get redirect instead.