#505: create startup script command #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added startup script command for Windows, Linux and MacOS (MacOS is not working yet) removed getBinaryName added WIP setMacOsFilePermissions
hohwille
reviewed
Aug 19, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Aug 19, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
removed setMacOsFilePermissions method from Intellij used makeExecutable from FileAccess instead
removed 2nd call of postInstall in LocalToolCommandlet
used MacOsHelper for the retrieval of the app path
removed thrown exception from makeExecutable
replaced createStartupScript in postInstall with postExtract simplified startup bash script fixed bug in extract method
…/jan-vcapgemini/IDEasy into feature/505-idea-startup-command
refactored create start script code into createStartScript method added createStartScript to android-studio added execute permissions to android-studio test files removed getBinaryName from android-studio added postExtract to android-studio
added escaped double quotes to dirname param
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java # cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Closed
5 tasks
Pull Request Test Coverage Report for Build 10826537383Details
💛 - Coveralls |
hohwille
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@jan-vcapgemini nicely completed. Great PR and finally solved various problems and previous workarounds. 👍
2 tasks
hohwille
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #440, #366, #505
Implements:
There is one issue left. On Mac starting
android-studiodoes not work becausestudiodoes not have execute permissions.