Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#330: fix CLI to prevent invalid shortoption split #530

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Aug 9, 2024

fixes #330

  • first I changed java mock command to work as originally proposed proxy command echo java $*
  • also improved IdeTestLoggerAssertion to support fluent API
  • found that EnvironmentCommandletTest fails on Windows (only) due to later changes not revealed by CI running on Linux
  • fixed that test.
  • Now added CliAdvancedParsingTest to verify and reproduce the bug that turned red
  • Now fixed the actual bug in AbstractIdeContext and ensured the new test turns green and all other tests remain green.

@hohwille hohwille requested a review from jan-vcapgemini August 9, 2024 13:56
@hohwille hohwille added this to the release:2024.08.001 milestone Aug 9, 2024
@hohwille hohwille added bugfix CLI IDEasy command-line-interface (parsing args, etc.) labels Aug 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10372052473

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.3%) to 64.149%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/property/KeywordProperty.java 1 72.73%
com/devonfw/tools/ide/property/BooleanProperty.java 10 10.2%
com/devonfw/tools/ide/context/AbstractIdeContext.java 18 62.89%
Totals Coverage Status
Change from base Build 10371250691: 1.3%
Covered Lines: 5643
Relevant Lines: 8471

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix of this nasty bug. I've added a question and some small CR's (mostly Javadoc)

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hohwille hohwille merged commit 3c1dcd1 into devonfw:main Aug 13, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CLI IDEasy command-line-interface (parsing args, etc.) reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

CLI misinterpretation of the first tool argument as combined short options - e.g. ide java -version
3 participants