Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#517 Fix get version throws exception when run on not-installed tool with installed flag #518

Merged
merged 3 commits into from
Aug 6, 2024
Merged

#517 Fix get version throws exception when run on not-installed tool with installed flag #518

merged 3 commits into from
Aug 6, 2024

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented Aug 6, 2024

Closes #517.

@slskiba slskiba self-assigned this Aug 6, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10266058017

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 62.82%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java 2 84.09%
Totals Coverage Status
Change from base Build 10265991513: 0.05%
Covered Lines: 5530
Relevant Lines: 8467
💛 - Coveralls

hohwille
hohwille approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for creating bug issue and PR fix. Great work and all solved perfectly correct 👍
Ready for merge.

@hohwille hohwille added this to the release:2024.08.001 milestone Aug 6, 2024
@hohwille hohwille merged commit 86e258c into devonfw:main Aug 6, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@slskiba slskiba

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.08.001
Development

Successfully merging this pull request may close these issues.

Get-version on a tool that is not installed throws an Exception
3 participants
@slskiba @coveralls @hohwille