Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#420: ensure os and architecture in filename #1092

Merged
merged 2 commits into from
Feb 27, 2025
Merged

#420: ensure os and architecture in filename #1092

merged 2 commits into from
Feb 27, 2025

Conversation

hohwille
Copy link
Member

improvement for #420
have os and architecture (windows-x64) in filename of MSI file.

@hohwille hohwille added windows specific for Microsoft Windows OS install installation process of IDE + tools and install commandlet labels Feb 27, 2025
@hohwille hohwille added this to the release:2025.02.002 milestone Feb 27, 2025
alfeilex
alfeilex approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@alfeilex alfeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfeilex alfeilex self-assigned this Feb 27, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13572408089

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.251%
Totals Coverage Status
Change from base Build 13572154944: 0.0%
Covered Lines: 7867
Relevant Lines: 11078
💛 - Coveralls

@hohwille hohwille merged commit 3dca8fe into devonfw:main Feb 27, 2025
3 checks passed
@hohwille hohwille linked an issue Feb 27, 2025 that may be closed by this pull request
Create installer for Windows #420
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfeilex alfeilex alfeilex approved these changes

Assignees

@alfeilex alfeilex

Labels
install installation process of IDE + tools and install commandlet windows specific for Microsoft Windows OS
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.002
Development

Successfully merging this pull request may close these issues.

Create installer for Windows
3 participants
@hohwille @coveralls @alfeilex