Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#420: exclude mac and linux content from MSI #1091

Conversation

hohwille
Copy link
Member

improvement for #420
since we copy the package content in a script code from the github action, the filters configured for assembly do not apply and linux and mac content gets included in windows MSI.

<exclude>system/mac/**</exclude>
<exclude>system/linux/**</exclude>

@hohwille hohwille added enhancement New feature or request windows specific for Microsoft Windows OS install installation process of IDE + tools and install commandlet labels Feb 27, 2025
@hohwille hohwille added this to the release:2025.02.002 milestone Feb 27, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13571070865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.255%

Totals Coverage Status
Change from base Build 13570888932: 0.0%
Covered Lines: 7867
Relevant Lines: 11077

💛 - Coveralls

Copy link
Member

@alfeilex alfeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hohwille hohwille merged commit df2cda5 into devonfw:main Feb 27, 2025
4 checks passed
@hohwille hohwille linked an issue Feb 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request install installation process of IDE + tools and install commandlet windows specific for Microsoft Windows OS
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create installer for Windows
3 participants