Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#944: improve handling of outputMessages in ProcessContextGitMock #1080

Merged
merged 3 commits into from
Feb 27, 2025
Merged

#944: improve handling of outputMessages in ProcessContextGitMock #1080

merged 3 commits into from
Feb 27, 2025

Conversation

paz-capgemini
Copy link
Contributor

Fixes #944

  • cleared the outputMessages before returning the ProcessResult

@paz-capgemini paz-capgemini self-assigned this Feb 25, 2025
@paz-capgemini paz-capgemini marked this pull request as ready for review February 25, 2025 14:36
@paz-capgemini paz-capgemini added enhancement New feature or request test related to testing and QA labels Feb 25, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13562251066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 68.229%
Totals Coverage Status
Change from base Build 13550239428: 0.007%
Covered Lines: 7861
Relevant Lines: 11073
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like described in the issue. Ready for review.

hohwille
hohwille approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paz-capgemini thanks for your PR. Implemented properly and ready for merge.

@hohwille hohwille added this to the release:2025.02.002 milestone Feb 27, 2025
@hohwille hohwille added the internal Nothing to be added to CHANGELOG, only internal story label Feb 27, 2025
@hohwille hohwille merged commit def882a into devonfw:main Feb 27, 2025
3 checks passed
julia-cap pushed a commit to julia-cap/IDEasy that referenced this pull request Feb 28, 2025
@paz-capgemini @jan-vcapgemini
@hohwille @julia-cap
devonfw#944: improve handling of outputMessages (devonfw#1080)
63c3551 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

@paz-capgemini paz-capgemini

Labels
enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story test related to testing and QA
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.002
Development

Successfully merging this pull request may close these issues.

Improve handling of ProcessContextGitMock.outputMessages
4 participants
@paz-capgemini @coveralls @hohwille @jan-vcapgemini