Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#789: implement uninstall of IDEasy #1071

Merged
merged 11 commits into from
Feb 26, 2025

Conversation

hohwille
Copy link
Member

fixed #789

@hohwille hohwille added enhancement New feature or request uninstall uninstall tools or IDEasy itself labels Feb 24, 2025
@hohwille hohwille added this to the release:2025.02.002 milestone Feb 24, 2025
@hohwille hohwille self-assigned this Feb 24, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2025

Pull Request Test Coverage Report for Build 13547675100

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 68.227%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/UninstallCommandlet.java 1 89.66%
com/devonfw/tools/ide/os/WindowsHelperImpl.java 21 0.0%
com/devonfw/tools/ide/tool/IdeasyCommandlet.java 23 79.24%
Totals Coverage Status
Change from base Build 13546685839: 0.2%
Covered Lines: 7860
Relevant Lines: 11071

💛 - Coveralls

@jan-vcapgemini jan-vcapgemini self-assigned this Feb 25, 2025
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the help of uninstall I think. Currently it only tells the user that it can be used to uninstall tools, but not that it can also uninstall IDEasy itself.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows. Most of the uninstall worked as expected. Approving as current CR can be solved later.

Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille hohwille merged commit 211057f into devonfw:main Feb 26, 2025
3 checks passed
julia-cap pushed a commit to julia-cap/IDEasy that referenced this pull request Feb 28, 2025
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uninstall uninstall tools or IDEasy itself
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add support to uninstall
3 participants