Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve XmlMergerTest to fail on errors #1069

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Improve XmlMergerTest to fail on errors #1069

merged 3 commits into from
Feb 25, 2025

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Feb 24, 2025 •
edited by hohwille
Loading

Implements:

  • made sure that XmlMerger tests will fail on errors

@jan-vcapgemini
devonfw#1068: Added test for advancedSettings issue
8112167 
made sure that XmlMerger tests will fail on errors
@jan-vcapgemini jan-vcapgemini self-assigned this Feb 24, 2025
@jan-vcapgemini jan-vcapgemini added bugfix merger settings ide-settings repo and replated processes and features labels Feb 24, 2025
@jan-vcapgemini
devonfw#1068: fixed test
7f59234 
added merge-id @key
changed order of entries
@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review February 24, 2025 15:56
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13502222288

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.964%
Totals Coverage Status
Change from base Build 13454667036: 0.0%
Covered Lines: 7765
Relevant Lines: 10983
💛 - Coveralls

@hohwille hohwille changed the title #1068: Fix advancedSettings merge Improve XmlMergerTest to fail on errors Feb 25, 2025
@hohwille hohwille merged commit cbacec9 into devonfw:main Feb 25, 2025
4 checks passed
@hohwille hohwille added this to the release:2025.02.002 milestone Feb 25, 2025
@jan-vcapgemini jan-vcapgemini added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille Awaiting requested review from hohwille

Assignees

@jan-vcapgemini jan-vcapgemini

Labels
bugfix merger reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. settings ide-settings repo and replated processes and features
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.002
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-vcapgemini @coveralls @hohwille