Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dependencies.json for LazyDocker and remove hardcoded dependency #1050

Open
hohwille opened this issue Feb 17, 2025 · 0 comments
Open
Labels
configuration should be configurable or configuration change dependency Tool dependencies (if tool A requires tool B) lazydocker urls ide-urls repo and related processes and features

Comments

@hohwille
Copy link
Member

hohwille commented Feb 17, 2025

Introduce dependencies.json for LazyDocker and remove hardcoded dependency:

@Override
protected void installDependencies() {
// TODO create lazydocker/lazydocker/dependencies.json file in ide-urls and delete this method
getCommandlet(Docker.class).install();
// verify docker API version requirements
String bashPath = this.context.findBashRequired();
ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.NONE).executable(bashPath)
.addArg("-c").addArg("docker").addArg("version").addArg("--format").addArg("'{{.Client.APIVersion}}'");
ProcessResult result = pc.run(ProcessMode.DEFAULT_CAPTURE);
verifyDockerVersion(result, MIN_API_VERSION, "docker API");
// verify docker compose version requirements
pc = this.context.newProcess().errorHandling(ProcessErrorHandling.NONE).executable(bashPath).addArg("-c").addArg("docker-compose").addArg("version")
.addArg("--short");
result = pc.run(ProcessMode.DEFAULT_CAPTURE);
verifyDockerVersion(result, MIN_COMPOSE_VERSION, "docker-compose");
}

@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Feb 17, 2025
@hohwille hohwille changed the title Introduce dependencies.json for LazyDocker and remove hardcoded dependency: https://github.com/devonfw/IDEasy/blob/4f2e37bf602a341666d12b62b09b633cbda05487/cli/src/main/java/com/devonfw/tools/ide/tool/lazydocker/LazyDocker.java#L35-L52 Introduce dependencies.json for LazyDocker and remove hardcoded dependency Feb 17, 2025
@hohwille hohwille added lazydocker configuration should be configurable or configuration change urls ide-urls repo and related processes and features dependency Tool dependencies (if tool A requires tool B) labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration should be configurable or configuration change dependency Tool dependencies (if tool A requires tool B) lazydocker urls ide-urls repo and related processes and features
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant