#439: Small changes after review

devonfw · Aug 13, 2024 · 0e336ee · 0e336ee
1 parent 9e02570
commit 0e336ee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
@@ -61,7 +61,7 @@ public Path getToolBinPath() {
 
   @Override
   protected boolean doInstall(boolean silent) {
-    
+
     return doInstall(null, silent);
   }
 
@@ -392,14 +392,13 @@ private void installDependencies(DependencyInfo dependencyInfo, EnvironmentConte
   private void installDependencyInRepo(String dependencyName, ToolCommandlet dependencyTool, VersionIdentifier dependencyVersionToInstall,
       EnvironmentContext ec) {
 
-    this.context.info("The version {} of the dependency {} is being installed", dependencyVersionToInstall, dependencyName);
-
     if (dependencyTool instanceof LocalToolCommandlet) {
+      this.context.info("The version {} of the dependency {} is being installed", dependencyVersionToInstall, dependencyName);
       ((LocalToolCommandlet) dependencyTool).installTool(ec, dependencyVersionToInstall);
+      this.context.info("The version {} of the dependency {} was successfully installed", dependencyVersionToInstall, dependencyName);
     } else {
-      // TODO
+      this.context.trace("The dependency is not an instance of LocalToolCommandlet, hence not able to be installed");
     }
-    this.context.info("The version {} of the dependency {} was successfully installed", dependencyVersionToInstall, dependencyName);
   }
 
 

diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/tomcat/Tomcat.java b/cli/src/main/java/com/devonfw/tools/ide/tool/tomcat/Tomcat.java
@@ -32,20 +32,7 @@ public Tomcat(IdeContext context) {
     super(context, "tomcat", Set.of(Tag.JAVA));
     add(this.arguments);
   }
-
-//@Override
-//  public void postInstall() {
-//
-//    super.postInstall();
-//
-//    EnvironmentVariables variables = this.context.getVariables();
-//    EnvironmentVariables typeVariables = variables.getByType(EnvironmentVariablesType.CONF);
-//
-//    typeVariables.set("CATALINA_HOME", getToolPath().toString(), true);
-//    typeVariables.save();
-//  }
-
-
+
   @Override
   public void runTool(ProcessMode processMode, VersionIdentifier toolVersion, String... args) {