Minor context leaks

devgianlu · Mar 17, 2019 · 37d6a53 · 37d6a53
1 parent 839ed16
commit 37d6a53
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/app/src/main/java/com/gianlu/aria2app/Activities/MoreAboutDownload/Peers/PeersAdapter.java b/app/src/main/java/com/gianlu/aria2app/Activities/MoreAboutDownload/Peers/PeersAdapter.java
@@ -26,7 +26,6 @@
 
 @UiThread
 public class PeersAdapter extends OrderedRecyclerViewAdapter<PeersAdapter.ViewHolder, Peer, PeersAdapter.SortBy, NotFilterable> {
-    private final Context context;
     private final Listener listener;
     private final LayoutInflater inflater;
     private final GeoIP geoIP;
@@ -35,7 +34,6 @@ public class PeersAdapter extends OrderedRecyclerViewAdapter<PeersAdapter.ViewHo
     PeersAdapter(Context context, @NonNull Listener listener) {
         super(new ArrayList<>(), SortBy.DOWNLOAD_SPEED);
         this.inflater = LayoutInflater.from(context);
-        this.context = context;
         this.listener = listener;
         this.geoIP = GeoIP.get();
     }
@@ -55,7 +53,7 @@ protected void onUpdateViewHolder(@NonNull ViewHolder holder, int position, @Non
     @Override
     protected void onUpdateViewHolder(@NonNull ViewHolder holder, int position, @NonNull Object payload) {
         if (payload instanceof IPDetails)
-            holder.flag.setImageDrawable(flags.loadFlag(context, ((IPDetails) payload).countryCode));
+            holder.flag.setImageDrawable(flags.loadFlag(holder.flag.getContext(), ((IPDetails) payload).countryCode));
     }
 
     @Override

diff --git a/...rc/main/java/com/gianlu/aria2app/Activities/MoreAboutDownload/Servers/ServersAdapter.java b/...rc/main/java/com/gianlu/aria2app/Activities/MoreAboutDownload/Servers/ServersAdapter.java
@@ -34,12 +34,10 @@ public class ServersAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder
     private final List<Object> objs;
     private final LayoutInflater inflater;
     private final Listener listener;
-    private final Context context;
     private final GeoIP geoIP;
     private final CountryFlags flags = CountryFlags.get();
 
     ServersAdapter(Context context, @NonNull Listener listener) {
-        this.context = context;
         this.listener = listener;
         this.objs = new ArrayList<>();
         this.geoIP = GeoIP.get();
@@ -121,7 +119,7 @@ public void onBindViewHolder(@NonNull RecyclerView.ViewHolder holder, int positi
                     castHolder.address.setText(server.currentUri);
                     castHolder.downloadSpeed.setText(CommonUtils.speedFormatter(server.downloadSpeed, false));
                 } else if (payload instanceof IPDetails) {
-                    castHolder.flag.setImageDrawable(flags.loadFlag(context, ((IPDetails) payload).countryCode));
+                    castHolder.flag.setImageDrawable(flags.loadFlag(castHolder.flag.getContext(), ((IPDetails) payload).countryCode));
                 }
             } else if (holder instanceof HeaderViewHolder) {
                 AriaFile file = (AriaFile) payloads.get(0);