Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features, Fixes, Chore. #12

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Features, Fixes, Chore. #12

merged 1 commit into from
Jan 23, 2025

Conversation

yackers
Copy link
Contributor

@yackers yackers commented Jan 23, 2025

Summary

This PR fixes/implements the following bugs/features:

  • Feature DocumentThumbnail - add instantiation from file path or uri #6: instantiation DocumentThumbnail fromUri() static method.
  • Feature: instantiation DocumentFile fromUri() static method.
  • Breaking changes: DocumentFile.open() & DocumentFile.share() updated, title parameter is optional from now. It was syntax error.
  • Chore: updated README.md, CHANGELOG.md, documentation, example, dependencies, gradle, kotlin, java.

How Has This Been Tested?

Example was updated, to use new & fixed methods.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Code style update (formatting, renaming).
  • Refactoring (no functional changes, no api changes).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation content changes.
  • Other (please describe):

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Closing Issues

Closes #11

@yackers
Features, Fixes, Chore.
88a7ec3 
- Feature: instantiation `DocumentThumbnail` `fromUri()` static method.
- Feature: instantiation `DocumentFile` `fromUri()` static method.
- Fixes: for `share()` `open()` - title is optional parameter
- Chore: updated README.md, CHANGELOG.md, documentation, example, dependencies, gradle, kotlin, java.

Signed-off-by: Alex Yackers <7115964+yackers@users.noreply.github.com>
@yackers yackers self-assigned this Jan 23, 2025
@yackers yackers added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 23, 2025
@yackers yackers merged commit b2f97d8 into main Jan 23, 2025
1 check passed
@yackers yackers deleted the feature/6-document-thumbnail-instantiation branch January 23, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yackers yackers

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DocumentThumbnail - add instantiation from file path or uri
1 participant
@yackers