-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed feature for .net aspire #1257
base: main
Are you sure you want to change the base?
Conversation
cc @joshspicer as he wrote the dotnet one (thanks) |
Hey @danmoseley! I'm cool with that, hopefully it'll be an official feature 😎 Let me know what you'd like me to do and when. |
tests pass locally; ready for review. |
fb55c4c
to
9dbe13a
Compare
0b69c2f
to
b7f6f8f
Compare
@joshspicer could you possibly have a look? and enable workflows if possible. |
Thank you @danmoseley @davidfowl for the contribution! @chrmarti @eljog if you get a moment, could you provide a review? Thanks so much! |
Prior art published from their own repos --
".NET Aspire" https://github.com/NikiforovAll/devcontainer-features
".NET Aspire Daily Builds" https://github.com/ElanHasson/devcontainer-features
Thank you @NikiforovAll and @ElanHasson for publishing these!
These happen to be at the top of the list:
![image](https://private-user-images.githubusercontent.com/6385855/408769813-44ca5177-52de-42be-83ac-31eb59a39146.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NzM1NTUsIm5iZiI6MTczODg3MzI1NSwicGF0aCI6Ii82Mzg1ODU1LzQwODc2OTgxMy00NGNhNTE3Ny01MmRlLTQyYmUtODNhYy0zMWViNTlhMzkxNDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMjAyMDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTEwZGFkMzQ3MjZiMzRhMzJmNTdiZWFmYjE1NmYxMDQxMWJlMmEyZThhM2RhYzMwYWE2Nzc0M2QxNjU5MDJkNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.eFx3nYH8vo4KyI9OwLhKIYNccsrqf57jLQpXHF1JFr4)
Both of these use the old way to install .NET Aspire, based on "dotnet workload". This only works with Aspire 8.0. From Aspire 9.0 onwards, this is no longer relevant. Anyone using Aspire today will likely want 9.0 or later.
I considered offering PR's to update each of them, but it seems to me that it would be better to have a single devcontainer feature for .NET Aspire which handled both scenarios plus arbitrary versions (>=9.0). This is that.
Merging this would require that the existing features be unpublished when this was merged, or this uses a different name. @NikiforovAll and @ElanHasson what would you think of replacing yours with a combined one?
cc @joperezr @davidfowl
When merged it could replace this line in the Aspire repo