Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less target columns in fiberassign files #279

Merged
merged 3 commits into from
Nov 26, 2020
Merged

Less target columns in fiberassign files #279

merged 3 commits into from
Nov 26, 2020

Conversation

forero
Copy link
Member

@forero forero commented Nov 25, 2020

Addresses #271 by reading a minimal set of columns from the target files to be propagated into the fiberassign files.

@forero forero requested a review from tskisner November 25, 2020 00:19
tskisner
tskisner approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for implementing this!

@forero
Copy link
Member Author

forero commented Nov 26, 2020

Thanks @tskisner !

@forero forero closed this Nov 26, 2020
@forero forero reopened this Nov 26, 2020
@forero forero merged commit 3c85dc8 into master Nov 26, 2020
@forero forero deleted the less_target_columns branch December 1, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forero @tskisner