Different issues/questions on fba_cmx script

[forero]

From @araichoor

1. fiberassign/bin/fba_cmx

   Lines 600 to 603 in 150d657

   	if os.path.isfile(root+'-targ.fits'):
   	dp = fits.open(root+'-targ.fits')[1].data
   	else:
   	dp = fits.open(root+'-std.fits')[1].data

   => as said, I don t see when the *targ.fits file cannot be here; would you have an example?

2. having a log file: I didn t find a quick solution to that; currently, all outputs are printed to the prompt, so it is not stored; I guess we should at least launch the code with "python fba_cmx ... > log_filename 2>&1", with the log file being root+".log"; I would have like to avoid that (for instance, if outdir is not created yet, the python call will crash) and to make it internal to the python script, but I didn t find how to do that... => if you don t have an obvious solution here, do you think you could re-run the tiles you generated, with a log file?

3. about the obscon: from the naming here https://github.com/forero/cmx-desi/tree/main/cmx_fiberassign/001513_bright_dithlost, I understand you ran dithlost with obscon=bright => we have to double-check with Eddie, but I think I remember he said we just don t care about obscon for dithering; in which case, we would just use "dark,bright" for dithprec and dithlost,

From @tskisner

4. I think that overall we should consider running an autoformatter on code. I usually run black locally when working on fiberassign python code, but there are other tools out there too. Anything to make sure that the code has basic compliance to PEP8.

5 more comments here: #277 (review)