Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph deployment race condition #786

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Graph deployment race condition #786

merged 4 commits into from
Jan 30, 2025

Conversation

kadamidev
Copy link
Contributor

Description of the Problem / Feature

  • In the graph/ganache startup script we ran the graph deployment first in the background and immediately after started ganache, with some arbitrary timeouts to let ganache start up, this worked fine for most machines however on some the graph deployment instance would spin up quickly and it relied upon ganache being ready, resulting in a race condition causing it to fail

Explanation of the solution

  • Started up ganache first in the background, and added a snippet to wait for ganache to be ready to take reqs first before proceeding with the graph deployment

@kadamidev kadamidev requested a review from m0ar January 23, 2025 05:50
@kadamidev kadamidev merged commit 84fde98 into develop Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ar m0ar Awaiting requested review from m0ar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kadamidev