Support ÖBB-style JIDs & fix #6 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as i've detailed in #6, the issue is that ÖBB uses much longer HAFAS IDs that don't share the DB HAFAS format. i've added logic to check if the current ID looks like an ÖBB style ID, and if so, extract the
$date_refvalue for cross-midnight correction from the right spot.i haven't tested this late at night yet (not sure if that's even necessary?) but testing with
--dateand--timeseems to confirm that the library can process cross-midnight journeys again:(for debugging i added the date to departure times, this is not part of the patch)