Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: larger artifact support #32

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Nov 19, 2024

Currently the artifact support is limited to 4 bytes for Elf since the size is limited to 4 bytes size declaration.
This creates rather funny situations where the binary size is correct, yet the find_section values only yield 4GB entries at most and head-truncate the actual payload.

I.e. in my case I got decapitated tar files which took a hot sec to triage.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.63%. Comparing base (ea77f17) to head (17ad19a).

Files with missing lines Patch % Lines
lib.rs 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files           2        2           
  Lines         521      521           
=======================================
  Hits          368      368           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@drahnr drahnr changed the title larger artifact support feat: larger artifact support Nov 19, 2024
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@littledivy littledivy merged commit 31fd373 into denoland:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants