Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to pass <sectionname> as first argument #31

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Nov 14, 2024

No description provided.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run cargo fmt to format the code? Thanks for the PR

@drahnr
Copy link
Contributor Author

drahnr commented Nov 18, 2024

Done.

Would you be interested in extending the CLI slightly using clap and avoiding to read the extra data to memory?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.63%. Comparing base (ea77f17) to head (1a5d656).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files           2        2           
  Lines         521      521           
=======================================
  Hits          368      368           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@drahnr drahnr changed the title feat: allow to pass <sectionname> as first argument feat: allow to pass <sectionname> as first argument Nov 19, 2024
@littledivy
Copy link
Member

Would you be interested in extending the CLI slightly using clap and avoiding to read the extra data to memory?

Sure! Feel free to open a PR/issue.

@littledivy littledivy merged commit f241ef3 into denoland:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants