Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PortableExecutable::set_icon #24

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Add PortableExecutable::set_icon #24

merged 3 commits into from
Aug 14, 2024

Conversation

littledivy
Copy link
Member

Closes #23

@littledivy littledivy mentioned this pull request Aug 14, 2024
Merged
@littledivy littledivy merged commit 873f326 into main Aug 14, 2024
3 checks passed
@littledivy littledivy deleted the win_icons branch August 14, 2024 17:20
littledivy added a commit to denoland/deno that referenced this pull request Aug 15, 2024
@littledivy
feat: deno compile --icon <ico> (#25039)
7ca95fc 
Add `--icon` flag to set deno compile'd executable icon on Windows.

```
deno compile --icon icon.ico game.tsx
```

Depends on denoland/sui#24

<img width="447" alt="image"
src="https://github.com/user-attachments/assets/7f6f3aa0-6872-4975-ae9d-06701b7684b8">

Closes #8912
@Systemcluster
Copy link

@littledivy Is there a reason you didn't enable the image feature from editpe to use its set_icon? Is it because you don't want the added weight of the formats it supports in sui? I'm working on release 0.2 and I wonder if there's anything on your wishlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set icons on Windows
2 participants
@littledivy @Systemcluster