feat: remove direct reqwest dependency from remote interface #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
commented
Apr 25, 2024
| @@ -1,3 +1,3 @@ | |||
| [toolchain] | |||
| channel = "1.73.0" | |||
| channel = "1.77.2" | |||
There was a problem hiding this comment.
Bumping MSRV for RPITIT
losfair
reviewed
Apr 26, 2024
Yes, it successfully connects. I was able to send requests as well. |
mmastrac
commented
Apr 26, 2024
| @@ -171,10 +213,67 @@ async fn basics() { | |||
| println!("remote"); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn watch() { | |||
There was a problem hiding this comment.
Added a watch test since this was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
denokvremote interface currently requires a specific, older version ofreqwestthat makes it difficult for consumers to integrate. This PR introduces aRemoteTransportandRemoteResponsetrait that allow for embedders to implement this remote over any sort of HTTP transport.