feat: atomic sum on v8 values #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this handle Number.NaN, Number.NEGATIVE_INFINITY, Number.POSITIVE_INFINITY ? |
Same as in JavaScript, because both V8 and Rust implement IEEE-754 floating point numbers. |
igorzi
reviewed
Dec 20, 2023
sqlite/backend.rs
Outdated
Comment on lines
327
to
335
| if matches!(operand, KvValue::U64(_)) { | ||
| mutate_le64( | ||
| tx, | ||
| &mutation.key, | ||
| "sum", | ||
| operand, | ||
| version, | ||
| |a, b| a.wrapping_add(b), | ||
| )?; |
There was a problem hiding this comment.
How can this code path be triggered from JS? By using Deno.AtomicOperation.mutate() method, and passing KvU64 value?
igorzi
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.