Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deno compile --icon <ico> #25039

Merged
merged 4 commits into from
Aug 15, 2024
Merged

feat: deno compile --icon <ico> #25039

merged 4 commits into from
Aug 15, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 14, 2024 •
edited
Loading

Add --icon flag to set deno compile'd executable icon on Windows.

deno compile --icon icon.ico game.tsx

Depends on denoland/sui#24

image

Closes #8912

@littledivy littledivy marked this pull request as ready for review August 14, 2024 17:21
bartlomieju
bartlomieju approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really cool!

@littledivy littledivy merged commit 7ca95fc into denoland:main Aug 15, 2024
17 checks passed
@littledivy littledivy deleted the deno_compile_icon branch August 15, 2024 04:42
@littledivy littledivy mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting the icon for deno compile output binary
2 participants
@littledivy @bartlomieju