forked from ringcentral/slate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for new gender attributes #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chability field * Update `long_gender` field to `gender_new` * Expand on what values the gender filter query can accept * Add documentation for gender_searchability field
andreas-venturini
changed the title
Update API due to gender and temp "long_gender" changes
Add documentation for new gender attributes
May 21, 2024
jjinkxy
force-pushed
the
filmmakers-5376-new-gender-concept
branch
from
May 21, 2024 10:53
433b906
to
5a5148c
Compare
andreas-venturini
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, needs some minor wording changes but I'll do these myself before merging
jjinkxy
changed the title
Add documentation for new gender attributes
Adds documentation for new gender attributes
Jun 10, 2024
* Old values still work, but are not documented anymore
andreas-venturini
approved these changes
Jul 8, 2024
jjinkxy
force-pushed
the
filmmakers-5376-new-gender-concept
branch
from
July 10, 2024 09:30
2ba3d8c
to
e2fe9fa
Compare
* Still available in :show
jjinkxy
force-pushed
the
filmmakers-5376-new-gender-concept
branch
from
July 10, 2024 09:30
e2fe9fa
to
db419a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/denkungsart/filmmakers/issues/5376