Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image for anyrun-sdk package #36310

Merged

Conversation

pro100broo
Copy link
Contributor

@pro100broo pro100broo commented Mar 19, 2025

Status

In Progress

Related Content Pull Request

Related PR: No.

Related Issues

Related: No.

Description

Add a new Docker image with anyrun-sdk dependency to the registry

@eyalpalo
Copy link
Contributor

@pro100broo Hey, does this PR related to a contribution? If not, can you elaborate about it?

@pro100broo
Copy link
Contributor Author

pro100broo commented Mar 19, 2025

Hello, @eyalpalo
I have started the adopt process for ANYRUN pack. Here is the PR

I need to use our company's Python SDK to create new automation scripts for this pack
Let me know if I was too hasty in publishing a new image and if I need to wait until the adopt process is complete

@eyalpalo
Copy link
Contributor

@pro100broo I see
As there is no other docker image with anyrun-sdk it might be indeed needed.
Let me know once you want to push it and think it's ready.

@pro100broo
Copy link
Contributor Author

Hey @eyalpalo
I would like to push the image to registry.
Can we continue this process?

Copy link
Contributor

@eyalpalo eyalpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, few minor changes

interval: daily - package-ecosystem: pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a blank line before this line

[dev-packages]

[requires]
python_version = "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python_version = "3.9"
python_version = "3.12"

@pro100broo
Copy link
Contributor Author

@eyalpalo
I made the necessary changes. Could u please check?

@JudahSchwartz JudahSchwartz merged commit fcf54b0 into demisto:master Mar 24, 2025
2 checks passed
Copy link

welcome bot commented Mar 24, 2025

Congrats on merging your first pull request! 🎉 How awesome!

@eyalpalo
Copy link
Contributor

@pro100broo Merged

@eyalpalo
Copy link
Contributor

The image should have been locked again, which caused it to fail on internal process... A fix PR is in progress #36376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants