Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL Phishing #39239

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update URL Phishing #39239

wants to merge 12 commits into from
+695 −737

Conversation

jlevypaloalto
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@jlevypaloalto jlevypaloalto requested a review from AradCarmi March 23, 2025 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PhishingURL/Scripts/DBotPredictURLPhishing
   DBotPredictURLPhishing.py3676382%121, 129, 137–138, 146, 157–158, 186–189, 191–192, 194–197, 206–210, 214, 218, 311–312, 385, 394, 402–403, 410, 451–453, 487–489, 537–538, 540–541, 552–553, 572–575, 621, 629–632, 654, 667, 671, 685, 690–691, 696, 718, 730, 733–734
Packs/PhishingURL/Scripts/DBotUpdateLogoURLPhishing
   DBotUpdateLogoURLPhishing.py1533477%49, 57–58, 83, 94–96, 100, 113–114, 156–158, 192, 196, 201–204, 209, 218, 238–244, 248–253
TOTAL5209781% 

Tests Skipped Failures Errors Time
7 0 💤 0 ❌ 0 🔥 3.257s ⏱️

AradCarmi
AradCarmi approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@AradCarmi AradCarmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@content-bot
Copy link
Collaborator

Validate summary

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AradCarmi AradCarmi AradCarmi approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlevypaloalto @content-bot @AradCarmi