Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable default sound for push notifications #21

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Mar 2, 2024

nb: i just guessed the syntax as i could not find documentation for DefaultNotificationBuilder, and also could not test the PR ;)

this PR sets the sound of the notification to "default".

sound or vibration can be disabled or changed by the user, but without specifying a sound in the APS json,
there will be never a sound and the user won't be able to enable one.

expected APS json syntax is described at
https://developer.apple.com/documentation/usernotifications/generating-a-remote-notification

sound or vibration can be disabled or changed by the user,
but without specifying a sound in the APS json,
there will be never a sound and the user won't be able to enable one.

expected APS json syntax is described at
https://developer.apple.com/documentation/usernotifications/generating-a-remote-notification
@r10s r10s requested a review from link2xt March 2, 2024 23:35
@link2xt
Copy link
Contributor

link2xt commented Mar 2, 2024

@link2xt link2xt merged commit f8fa39f into main Mar 2, 2024
2 checks passed
@r10s
Copy link
Member Author

r10s commented Mar 2, 2024

Documentation is here: https://docs.rs/a2/latest/a2/request/notification/struct.DefaultNotificationBuilder.html

thanks! somehow i was search in python land, lots of confusions with all these languages and parts :) thanks a lot for keeping an overview :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants