feat: add /notify endpoint #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/notify-endpoint
branch
from
6b5393e to
f475be5
Compare
hpk42
reviewed
Feb 27, 2024
src/server.rs
Outdated
| async fn notify_device(mut req: tide::Request<State>) -> tide::Result<tide::Response> { | ||
| let token_encrypted = req.body_string().await?; // or body_bytes for Vec<u8> | ||
| info!("Got direct notification for {token_encrypted}."); | ||
| // TODO decrypt token with pgp and notify that it got new messages. |
There was a problem hiding this comment.
for a first landing of PRs we could also not do the encryption/decryption ... the chatmail instance then sees the cleartext token but it's unclear anyway how much this is a problem. I regard the core2notification-server encryption as an optimization that could come after it works (maybe even on a new endpoint then).
hpk42
approved these changes
Feb 27, 2024
link2xt
force-pushed
the
link2xt/notify-endpoint
branch
3 times, most recently
from
5a0170a to
1367a96
Compare
r10s
approved these changes
Mar 2, 2024
Co-authored-by: bjoern <r10s@b44t.com>
link2xt
force-pushed
the
link2xt/notify-endpoint
branch
from
6862166 to
7874c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to use OpenPGP to encrypt tokens.