Parallelize notification sending #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is much faster but hits ratelimits, Apple starts sending GOAWAY frames and then closes the connection so we get "broken pipe" before notifying everyone. We should probably ratelimit ourselves then or react to HTTP errors by waiting for some exponential backoff. |
link2xt
force-pushed
the
link2xt/parallelize-notifications
branch
from
7a4cf46 to
481341f
Compare
link2xt
force-pushed
the
link2xt/parallelize-notifications
branch
from
481341f to
1698ea5
Compare
|
Replaced with #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.