Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix showing input bar after forwarding #2165

Merged
merged 1 commit into from
May 12, 2024
Merged

fix showing input bar after forwarding #2165

merged 1 commit into from
May 12, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented May 11, 2024

this commit shows the forward-confirmation-alert
to after the view controller is really created.

otherwise, on some iOS versions,
the alert interferes with setting up the view controller in viewWillAppear

tested on iphone13/ios17.4, iphone7/ios15 and emulator/ios17.0

closes #2153

this commit shows the forward-confirmation-alert
to _after_ the view controller is really created.

otherwise, on some iOS versions,
the alert interferes with setting up the view controller in viewWillAppear

closes #2153
@r10s r10s added the bug label May 11, 2024
@r10s r10s requested a review from zeitschlag May 11, 2024 18:04
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, nice catch!

@r10s r10s merged commit 947f27f into main May 12, 2024
1 check passed
@r10s r10s deleted the r10s/fix-forwarding branch May 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

message input bar disappears after forwarding
2 participants