Skip to content

Commit

Permalink
streamline help menu
Browse files Browse the repository at this point in the history
- use clear "Delta Chat Homepage" for opening our homepage
  (instead of unclear "Learn more about Delta Chat",
  which is esp. weird, when used from inside the help)

- do not "promote" GitHub in our menu entry,
  instead of "Contribute on GitHub", just say "Contribute".
  destination URL is our contribute page then -
  that is also more useful for ppl doing eg. translations
  • Loading branch information
r10s committed Jan 22, 2025
1 parent 9ac5e71 commit 3c737f2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
openOnlineUrl("https://delta.chat/gdpr");
return true;
case R.id.contribute:
openOnlineUrl("https://github.com/deltachat/deltachat-android");
openOnlineUrl("https://delta.chat/contribute");
return true;
case R.id.report_issue:
openOnlineUrl("https://github.com/deltachat/deltachat-android/issues");
Expand Down
4 changes: 2 additions & 2 deletions src/main/res/menu/local_help.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
<item android:title="@string/menu_scroll_to_top"
android:id="@+id/log_scroll_up" />

<item android:title="@string/global_menu_help_learn_desktop"
<item android:title="@string/delta_chat_homepage"
android:id="@+id/learn_more"
app:showAsAction="never"/>

<item android:title="@string/privacy_policy"
android:id="@+id/privacy_policy"
app:showAsAction="never"/>

<item android:title="@string/global_menu_help_contribute_desktop"
<item android:title="@string/contribute"
android:id="@+id/contribute"
app:showAsAction="never"/>

Expand Down
4 changes: 4 additions & 0 deletions src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1086,8 +1086,12 @@
<string name="global_menu_view_developer_desktop">Developer</string>
<string name="global_menu_view_developer_tools_desktop">Developer Tools</string>
<string name="global_menu_help_desktop">Help</string>
<!-- deprecated, use delta_chat_homepage instead -->
<string name="global_menu_help_learn_desktop">Learn more about Delta Chat</string>
<string name="delta_chat_homepage">Delta Chat Homepage</string>
<!-- deprecated, use contribute instead -->
<string name="global_menu_help_contribute_desktop">Contribute on GitHub</string>
<string name="contribute">Contribute</string>
<string name="global_menu_help_report_desktop">Report an Issue</string>
<string name="global_menu_help_about_desktop">About Delta Chat</string>
<string name="global_menu_file_open_desktop">Open Delta Chat</string>
Expand Down

0 comments on commit 3c737f2

Please sign in to comment.